Skip to content

[Draft] Add post-quantum key exchange to compute ssl policy resources#17024

Draft
jcqli wants to merge 5 commits intoGoogleCloudPlatform:mainfrom
jcqli:pqke
Draft

[Draft] Add post-quantum key exchange to compute ssl policy resources#17024
jcqli wants to merge 5 commits intoGoogleCloudPlatform:mainfrom
jcqli:pqke

Conversation

@jcqli
Copy link
Copy Markdown
Contributor

@jcqli jcqli commented Apr 8, 2026

b/458421784 Adds post-quantum key exchange to ssl policies api

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `post_quantum_key_exchange` field to `google_compute_ssl_policy` and `google_compute_region_ssl_policy` resources

@github-actions github-actions bot requested a review from zli82016 April 8, 2026 19:55
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 457 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 10 files changed, 457 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 10 files changed, 87 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 121 insertions(+))

Missing doc report (experimental)

The following data sources are missing documents:

  • google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1408
Passed tests: 1313
Skipped tests: 90
Affected tests: 5

Click here to see the affected service packages
  • compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionSslPolicy_postQuantumKeyExchange
  • TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeSslPolicy_postQuantumKeyExchange
  • TestAccComputeSslPolicy_sslPolicyBasicExample

Get to know how VCR tests work

@jcqli jcqli marked this pull request as draft April 8, 2026 20:42
@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_UpdateMd5AuthenticationKey [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeRegionSslPolicy_postQuantumKeyExchange [Error message] [Debug log]
TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample [Error message] [Debug log]
TestAccComputeSslPolicy_postQuantumKeyExchange [Error message] [Debug log]
TestAccComputeSslPolicy_sslPolicyBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 457 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 10 files changed, 457 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 10 files changed, 87 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 121 insertions(+))

Missing doc report (experimental)

The following data sources are missing documents:

  • google_compute_region_ssl_policy, expect file /website/docs/d/compute_region_ssl_policy.html.markdown to exist.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1408
Passed tests: 1314
Skipped tests: 90
Affected tests: 4

Click here to see the affected service packages
  • compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionSslPolicy_postQuantumKeyExchange
  • TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample
  • TestAccComputeSslPolicy_postQuantumKeyExchange
  • TestAccComputeSslPolicy_sslPolicyBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRegionSslPolicy_postQuantumKeyExchange [Error message] [Debug log]
TestAccComputeRegionSslPolicy_regionSslPolicyBasicExample [Error message] [Debug log]
TestAccComputeSslPolicy_postQuantumKeyExchange [Error message] [Debug log]
TestAccComputeSslPolicy_sslPolicyBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants