Remove launch_stage = BETA from Cloud Run WorkerPool tests and examples#17029
Conversation
Cloud Run WorkerPools API is now GA. Removed launch_stage = BETA from all WorkerPool test cases and examples since launch_stage defaults to GA when not specified.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 88 Click here to see the affected service packages
Action takenFound 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🟢 All tests passed! |
zli82016
left a comment
There was a problem hiding this comment.
Thanks for fixing these. Can you also fix these tests?
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolGcsVolume
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMountGcsExample
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMountNfsExample
TestAccCloudRunV2WorkerPool_vpcAccess_basic
Thanks.
The test will be deprecated in a separate PR, but keeping it for now with the launch_stage fix since the API now defaults to GA.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 88 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Cloud Run WorkerPools API is now GA. Removed launch_stage = BETA from all WorkerPool test cases and examples since launch_stage defaults to GA when not specified.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.