Skip to content

Remove launch_stage = BETA from Cloud Run WorkerPool tests and examples#17029

Merged
zli82016 merged 2 commits intoGoogleCloudPlatform:mainfrom
kminsu-google:worker-pools-launch-stage
Apr 9, 2026
Merged

Remove launch_stage = BETA from Cloud Run WorkerPool tests and examples#17029
zli82016 merged 2 commits intoGoogleCloudPlatform:mainfrom
kminsu-google:worker-pools-launch-stage

Conversation

@kminsu-google
Copy link
Copy Markdown
Member

@kminsu-google kminsu-google commented Apr 8, 2026

Cloud Run WorkerPools API is now GA. Removed launch_stage = BETA from all WorkerPool test cases and examples since launch_stage defaults to GA when not specified.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudrunv2: `google_cloud_run_v2_worker_pool` resource now defaults `launch_stage` to `GA` (ga)

Cloud Run WorkerPools API is now GA. Removed launch_stage = BETA from all
WorkerPool test cases and examples since launch_stage defaults to GA when
not specified.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 8, 2026
@github-actions github-actions bot requested a review from NickElliot April 8, 2026 22:46
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@zli82016 zli82016 requested review from zli82016 and removed request for NickElliot April 8, 2026 22:49
@modular-magician modular-magician added service/run and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 8, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 38 deletions(-))
google-beta provider: Diff ( 5 files changed, 38 deletions(-))
Open in Cloud Shell: Diff ( 11 files changed, 11 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 88
Passed tests: 61
Skipped tests: 9
Affected tests: 18

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2WorkerPoolIamBindingGenerated
  • TestAccCloudRunV2WorkerPoolIamMemberGenerated
  • TestAccCloudRunV2WorkerPoolIamPolicyGenerated
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolAttributionLabel
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolBasicDependsOnExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolBasicExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolDirectvpcExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolFullUpdate
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolGpuExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolLimitsExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMulticontainerExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolSecretExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolSqlExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolStartupLivenessProbeExample
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithDirectVPCUpdate
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithManualInstanceCountZero
  • TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithManualScaling
  • TestAccDataSourceGoogleCloudRunV2WorkerPool_basic

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2WorkerPoolIamBindingGenerated [Debug log]
TestAccCloudRunV2WorkerPoolIamMemberGenerated [Debug log]
TestAccCloudRunV2WorkerPoolIamPolicyGenerated [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolAttributionLabel [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolBasicDependsOnExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolBasicExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolDirectvpcExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolFullUpdate [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolGpuExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolLimitsExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMulticontainerExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolSecretExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolSqlExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolStartupLivenessProbeExample [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithDirectVPCUpdate [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithManualInstanceCountZero [Debug log]
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolWithManualScaling [Debug log]
TestAccDataSourceGoogleCloudRunV2WorkerPool_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Copy Markdown
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these. Can you also fix these tests?

TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolGcsVolume
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMountGcsExample
TestAccCloudRunV2WorkerPool_cloudrunv2WorkerPoolMountNfsExample
TestAccCloudRunV2WorkerPool_vpcAccess_basic

Thanks.

The test will be deprecated in a separate PR, but keeping it for now with the launch_stage fix since the API now defaults to GA.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 9, 2026
@github-actions github-actions bot requested a review from zli82016 April 9, 2026 00:12
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 9, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 39 deletions(-))
google-beta provider: Diff ( 6 files changed, 39 deletions(-))
Open in Cloud Shell: Diff ( 11 files changed, 11 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 88
Passed tests: 78
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunV2WorkerPool_vpcAccess_basic

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunV2WorkerPool_vpcAccess_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants