Terraform support for EnrichmentService#17035
Terraform support for EnrichmentService#17035joaquinbadillog wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_enrichment_control" "primary" {
description = # value needed
display_name = # value needed
enrichment_control_option {
enrichment_source {
external_enrichment_source = # value needed
log_type = # value needed
}
enrichment_type = # value needed
target_log_type = # value needed
}
instance = # value needed
location = # value needed
}
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_enrichment_control" "primary" {
description = # value needed
display_name = # value needed
enrichment_control_option {
enrichment_source {
external_enrichment_source = # value needed
log_type = # value needed
}
enrichment_type = # value needed
target_log_type = # value needed
}
instance = # value needed
location = # value needed
}
|
Tests analyticsTotal tests: 38 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_chronicle_enrichment_control" "primary" {
description = # value needed
display_name = # value needed
enrichment_control_option {
enrichment_source {
external_enrichment_source = # value needed
log_type = # value needed
}
enrichment_type = # value needed
target_log_type = # value needed
}
instance = # value needed
location = # value needed
}
|
Tests analyticsTotal tests: 38 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Tests analyticsTotal tests: 38 Click here to see the affected service packages
🟢 All tests passed! View the build log |
feat: Add Terraform support for Chronicle EnrichmentControlService API
This pull request introduces a new Terraform resource to the Chronicle product.
Note that Enrichment Controls cannot be updated or deleted, therefore only the Create operation was implemented and tested.
Key changes include:
Resource definition in mmv1/products/chronicle/EnrichmentControl.yaml
A custom decoder implemented in mmv1/templates/terraform/decoders/chronicle_enrichment_control_id.go.tmpl
An example file to add test coverage for CreateEnrichmentControl