Skip to content

Terraform support for EnrichmentService#17035

Open
joaquinbadillog wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
joaquinbadillog:chronicle-enrichmentcontrols-joaquinbadillo
Open

Terraform support for EnrichmentService#17035
joaquinbadillog wants to merge 4 commits intoGoogleCloudPlatform:mainfrom
joaquinbadillog:chronicle-enrichmentcontrols-joaquinbadillo

Conversation

@joaquinbadillog
Copy link
Copy Markdown

feat: Add Terraform support for Chronicle EnrichmentControlService API

This pull request introduces a new Terraform resource to the Chronicle product.
Note that Enrichment Controls cannot be updated or deleted, therefore only the Create operation was implemented and tested.

Key changes include:

Resource definition in mmv1/products/chronicle/EnrichmentControl.yaml
A custom decoder implemented in mmv1/templates/terraform/decoders/chronicle_enrichment_control_id.go.tmpl
An example file to add test coverage for CreateEnrichmentControl

@github-actions github-actions bot requested a review from roaks3 April 9, 2026 00:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 209 insertions(+))
google-beta provider: Diff ( 4 files changed, 1012 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_enrichment_control (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_enrichment_control" "primary" {
  description  = # value needed
  display_name = # value needed
  enrichment_control_option {
    enrichment_source {
      external_enrichment_source = # value needed
      log_type                   = # value needed
    }
    enrichment_type = # value needed
    target_log_type = # value needed
  }
  instance = # value needed
  location = # value needed
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 209 insertions(+))
google-beta provider: Diff ( 4 files changed, 1012 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_enrichment_control (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_enrichment_control" "primary" {
  description  = # value needed
  display_name = # value needed
  enrichment_control_option {
    enrichment_source {
      external_enrichment_source = # value needed
      log_type                   = # value needed
    }
    enrichment_type = # value needed
    target_log_type = # value needed
  }
  instance = # value needed
  location = # value needed
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • chronicle

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 209 insertions(+))
google-beta provider: Diff ( 4 files changed, 1012 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 222 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_enrichment_control (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_enrichment_control" "primary" {
  description  = # value needed
  display_name = # value needed
  enrichment_control_option {
    enrichment_source {
      external_enrichment_source = # value needed
      log_type                   = # value needed
    }
    enrichment_type = # value needed
    target_log_type = # value needed
  }
  instance = # value needed
  location = # value needed
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • chronicle

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • chronicle

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants