Converted DCL resources to use registry#17060
Converted DCL resources to use registry#17060melinath merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
@modular-magician reassign-reviewer @c2thorn |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 277 Click here to see the affected service packages
🟢 All tests passed! View the build log |
c2thorn
left a comment
There was a problem hiding this comment.
seems very straightforward, thanks for the terraform providers schema check
This is a follow-up to #16705 to convert the provider_dcl_resources file as well. I used
TF_CLI_CONFIG_FILE="./tf-dev-override.tfrc" terraform providers schema -json | jqto confirm zero diff in the beta provider schema before/after this change. (I didn't check ga because there aren't any google-specific changes made).I don't see any EAP conflicts for this change.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.