Skip to content

Converted DCL resources to use registry#17060

Merged
melinath merged 1 commit intoGoogleCloudPlatform:mainfrom
melinath:dcl-registry-usage
Apr 9, 2026
Merged

Converted DCL resources to use registry#17060
melinath merged 1 commit intoGoogleCloudPlatform:mainfrom
melinath:dcl-registry-usage

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented Apr 9, 2026

This is a follow-up to #16705 to convert the provider_dcl_resources file as well. I used TF_CLI_CONFIG_FILE="./tf-dev-override.tfrc" terraform providers schema -json | jq to confirm zero diff in the beta provider schema before/after this change. (I didn't check ga because there aren't any google-specific changes made).

I don't see any EAP conflicts for this change.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@melinath
Copy link
Copy Markdown
Member Author

melinath commented Apr 9, 2026

@modular-magician reassign-reviewer @c2thorn

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 210 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 19 files changed, 210 insertions(+), 29 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 277
Passed tests: 267
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages
  • containerazure
  • gkehub
  • apikeys
  • assuredworkloads
  • dataplex
  • dataproc
  • firebaserules
  • recaptchaenterprise
  • cloudbuild
  • clouddeploy
  • containeraws

🟢 All tests passed!

View the build log

Copy link
Copy Markdown
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems very straightforward, thanks for the terraform providers schema check

@melinath melinath added this pull request to the merge queue Apr 9, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 8a512dd Apr 9, 2026
25 checks passed
@melinath melinath deleted the dcl-registry-usage branch April 9, 2026 20:40
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants