Skip to content

feat(alloydb): Add trackClientAddress field to AlloyDB observability config#17067

Open
SamuPert wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
SamuPert:samupert/alloydb-observability-instance-config
Open

feat(alloydb): Add trackClientAddress field to AlloyDB observability config#17067
SamuPert wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
SamuPert:samupert/alloydb-observability-instance-config

Conversation

@SamuPert
Copy link
Copy Markdown

@SamuPert SamuPert commented Apr 9, 2026

Adds the trackClientAddress field to observability_config in google_alloydb_instance.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

alloydb: added `track_client_address` field to `google_alloydb_instance` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/alloydb and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 13, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+))
google-beta provider: Diff ( 4 files changed, 31 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 90
Passed tests: 76
Skipped tests: 3
Affected tests: 11

Click here to see the affected service packages
  • alloydb

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAlloydbInstance_ObservabilityConfig_Update
  • TestAccAlloydbInstance_clientConnectionConfig
  • TestAccAlloydbInstance_connectionPoolConfig
  • TestAccAlloydbInstance_networkConfig
  • TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag
  • TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig
  • TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig
  • TestAccAlloydbInstance_stopstart
  • TestAccAlloydbInstance_update
  • TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs
  • TestAccAlloydbInstance_updatePscInstanceConfig

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAlloydbInstance_ObservabilityConfig_Update [Debug log]
TestAccAlloydbInstance_clientConnectionConfig [Debug log]
TestAccAlloydbInstance_connectionPoolConfig [Debug log]
TestAccAlloydbInstance_networkConfig [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig [Debug log]
TestAccAlloydbInstance_stopstart [Debug log]
TestAccAlloydbInstance_update [Debug log]
TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs [Debug log]
TestAccAlloydbInstance_updatePscInstanceConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions
Copy link
Copy Markdown

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants