Skip to content

[Dataform] Promote google_dataform_folder and google_dataform_team_folder to GA#17068

Merged
c2thorn merged 3 commits intoGoogleCloudPlatform:mainfrom
sdsilva1:promote-teamfolder-ga
Apr 10, 2026
Merged

[Dataform] Promote google_dataform_folder and google_dataform_team_folder to GA#17068
c2thorn merged 3 commits intoGoogleCloudPlatform:mainfrom
sdsilva1:promote-teamfolder-ga

Conversation

@sdsilva1
Copy link
Copy Markdown
Contributor

@sdsilva1 sdsilva1 commented Apr 9, 2026

Fixes hashicorp/terraform-provider-google#26861
Fixes hashicorp/terraform-provider-google#26864

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

dataform: promoted `google_dataform_folder` to GA
dataform: promoted `google_dataform_team_folder` to GA

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@sdsilva1 sdsilva1 marked this pull request as draft April 9, 2026 22:56
@sdsilva1 sdsilva1 marked this pull request as ready for review April 9, 2026 23:50
@sdsilva1 sdsilva1 changed the title [Dataform] Promote google_dataform_team_folder to GA [Dataform] Promote google_dataform_folder and google_dataform_team_folder to GA Apr 10, 2026
@c2thorn c2thorn requested review from c2thorn and removed request for malhotrasagar2212 April 10, 2026 16:18
@modular-magician modular-magician added service/dataform and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 10, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 2087 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 6 files changed, 13 insertions(+), 29 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 15 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 321 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataform_folder, google_dataform_team_folder. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataformFolder_dataformFolderBasicExample
  • TestAccDataformFolder_dataformFolderFullExample
  • TestAccDataformFolder_update
  • TestAccDataformTeamFolder_dataformTeamFolderBasicExample
  • TestAccDataformTeamFolder_update

Tests analytics

Total tests: 17
Passed tests: 14
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • dataform

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformConfig_update
  • TestAccDataformFolder_dataformFolderFullExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_update [Debug log]
TestAccDataformFolder_dataformFolderFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 10, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 2087 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 6 files changed, 13 insertions(+), 29 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 15 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 321 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataform_folder, google_dataform_team_folder. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataformFolder_dataformFolderBasicExample
  • TestAccDataformFolder_dataformFolderFullExample
  • TestAccDataformFolder_update
  • TestAccDataformTeamFolder_dataformTeamFolderBasicExample
  • TestAccDataformTeamFolder_update

Tests analytics

Total tests: 17
Passed tests: 15
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataform

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataformConfig_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataformConfig_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Copy Markdown
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA tests passed. Failing tests have to be unrelated, as the beta downstream changes only affect Dataform Folder resources.

Waiting on one final TC build, but otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Terraform support for Cloud Dataform TeamFolder in GA provider Add Terraform support for Cloud Dataform Folder in GA provider

4 participants