[Dataform] Promote google_dataform_folder and google_dataform_team_folder to GA#17068
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Multiple resources addedThis PR adds multiple new resources: |
Non-exercised tests🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 17 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Multiple resources addedThis PR adds multiple new resources: |
Non-exercised tests🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 17 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
c2thorn
left a comment
There was a problem hiding this comment.
GA tests passed. Failing tests have to be unrelated, as the beta downstream changes only affect Dataform Folder resources.
Waiting on one final TC build, but otherwise LGTM
f71b9d4
Fixes hashicorp/terraform-provider-google#26861
Fixes hashicorp/terraform-provider-google#26864
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.