Skip to content

Migrate data_source_google_compute_region_instance_group to use trans…#17072

Draft
jcromanu wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jcromanu:data_source_google_compute_region_instance_group
Draft

Migrate data_source_google_compute_region_instance_group to use trans…#17072
jcromanu wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jcromanu:data_source_google_compute_region_instance_group

Conversation

@jcromanu
Copy link
Copy Markdown

…port_tpg.SendRequest

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `google_compute_region_instance_group` data source to use direct HTTP rather than a client library

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 10, 2026
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from roaks3 April 10, 2026 04:09
@modular-magician modular-magician added service/compute-networking-ig and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 10, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 54 insertions(+), 29 deletions(-))
google-beta provider: Diff ( 1 file changed, 54 insertions(+), 29 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1407
Passed tests: 1310
Skipped tests: 90
Affected tests: 7

Click here to see the affected service packages
  • compute

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceGroup_basic
  • TestAccComputeInstanceGroup_outOfOrderInstances
  • TestAccComputeInstanceGroup_rename
  • TestAccComputeInstanceGroup_update
  • TestAccComputeRegionBackendService_ilbUpdateFull
  • TestAccComputeSharedReservation_update
  • TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeSharedReservation_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceGroup_basic [Error message] [Debug log]
TestAccComputeInstanceGroup_outOfOrderInstances [Error message] [Debug log]
TestAccComputeInstanceGroup_rename [Error message] [Debug log]
TestAccComputeInstanceGroup_update [Error message] [Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull [Error message] [Debug log]
TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@jcromanu jcromanu marked this pull request as draft April 10, 2026 15:24
@jcromanu jcromanu marked this pull request as draft April 10, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants