Skip to content

Migrated compute machine types datasource to use transport_tpg.SendRequest#17076

Open
nsamartsev wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
nsamartsev:data-source-google-compute-machine-types-migration
Open

Migrated compute machine types datasource to use transport_tpg.SendRequest#17076
nsamartsev wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
nsamartsev:data-source-google-compute-machine-types-migration

Conversation

@nsamartsev
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: migrated `data_source_google_compute_machine_types` datasource to use direct HTTP rather than a client library

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 53 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 1 file changed, 56 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 The provider crashed while running the VCR tests in REPLAYING mode
Please fix it to complete your PR.
View the build log

@nsamartsev nsamartsev force-pushed the data-source-google-compute-machine-types-migration branch from d465185 to d062cba Compare April 10, 2026 17:44
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 58 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 1 file changed, 61 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 58 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 1 file changed, 61 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1407
Passed tests: 1317
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 1407
Passed tests: 1317
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@nsamartsev nsamartsev marked this pull request as ready for review April 10, 2026 19:04
@github-actions github-actions bot requested a review from roaks3 April 10, 2026 19:05
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@slevenick slevenick requested review from slevenick and removed request for roaks3 April 10, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants