Skip to content

Add 'principal' field to ReservationAssignment.yaml#17080

Draft
vasilyl wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
vasilyl:patch-14
Draft

Add 'principal' field to ReservationAssignment.yaml#17080
vasilyl wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
vasilyl:patch-14

Conversation

@vasilyl
Copy link
Copy Markdown
Contributor

@vasilyl vasilyl commented Apr 10, 2026

Added 'principal' field to ReservationAssignment.yaml with details on its usage and supported formats.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigquery: Added 'principal' field to ReservationAssignment resource

vasilyl added 2 commits April 10, 2026 14:35
Added 'principal' field to ReservationAssignment.yaml with details on its usage and supported formats.
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 38 insertions(+))
google-beta provider: Diff ( 3 files changed, 38 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_reservation_assignment (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_reservation_assignment" "primary" {
  principal = # value needed
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigqueryreservation

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants