Add 'principal' field to ReservationAssignment.yaml#17080
Draft
vasilyl wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Draft
Add 'principal' field to ReservationAssignment.yaml#17080vasilyl wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
vasilyl wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
Added 'principal' field to ReservationAssignment.yaml with details on its usage and supported formats.
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_bigquery_reservation_assignment" "primary" {
principal = # value needed
}
|
Collaborator
Tests analyticsTotal tests: 14 Click here to see the affected service packages
🟢 All tests passed! View the build log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'principal' field to ReservationAssignment.yaml with details on its usage and supported formats.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.