Terraform provider docs update

[chrisst]

upstream changes from hashicorp/terraform-provider-google#4795

I upstreamed the PR from @findkim, then had to make some updates on top of that. Including changes to the templating to generate the docs and manually adding subcategories for datasources.

I updated the datasources to have categories that are the same as their Resource equivalents. I believe this will nest them in the appropriate place, but we can revert that commit if we want to keep all datasources together.

Release Note Template for Downstream PRs (will be copied)

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 56c571c.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1330
depends: hashicorp/terraform-provider-google#4815

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3315bab.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 790d1dc.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[danawillow]

I think as best as possible it makes sense to use the product names from https://cloud.google.com/products/ (so say cloud when it says cloud, otherwise don't). I'm also not convinced we need "Google" in front of all of them since the user should already be aware that they're looking at Google stuff. What do you think?

[chrisst]

@danawillow yeah it looks like the generated resources omit the "Google" somewhat frequently so probably time to make the cutover.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, fec1982.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 519b1f4.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 00463c2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[danawillow]

Took a look at the generated output, here are my notes on things that should probably be changed:

• BigQueryDataTransfer
• BigTable vs Bigtable
• Google Cloud Run -> Cloud Run
• Dataproc vs Cloud Dataproc
• Key Management Service vs Cloud KMS
• Cloud Pub/Sub vs PubSub
• RuntimeConfig vs Cloud Runtime Configuration
• Cloud Spanner vs Spanner
• Cloud SQL vs SQL
• Google Cloud TPU -> Cloud TPU (and add the tpu data source there too probably)

[chrisst]

@danawillow yup I was just finishing my cleanup. I am thinking of keeping some of the cleanup for things like "BigTable" vs "Bigtable" in separate PR's because I'm not yet sure how it will affect the other downstreams.

here are the current subcategories:

subcategory: "Access Context Manager"
subcategory: "App Engine"
subcategory: "BigQuery"
subcategory: "BigQueryDataTransfer"
subcategory: "BigTable"
subcategory: "Bigtable"
subcategory: "Binary Authorization"
subcategory: "Cloud Build"
subcategory: "Cloud Composer"
subcategory: "Cloud DNS"
subcategory: "Cloud Dataproc"
subcategory: "Cloud Filestore"
subcategory: "Cloud Firestore"
subcategory: "Cloud Functions"
subcategory: "Cloud Healthcare"
subcategory: "Cloud IoT Core"
subcategory: "Cloud KMS"
subcategory: "Cloud Memorystore"
subcategory: "Cloud Platform"
subcategory: "Cloud Pub/Sub"
subcategory: "Cloud Runtime Configuration"
subcategory: "Cloud SQL"
subcategory: "Cloud Scheduler"
subcategory: "Cloud Security Command Center"
subcategory: "Cloud Security Scanner"
subcategory: "Cloud Source Repositories"
subcategory: "Cloud Spanner"
subcategory: "Cloud Storage Transfer"
subcategory: "Cloud Storage"
subcategory: "Compute Engine"
subcategory: "Container Registry"
subcategory: "Dataflow"
subcategory: "Dataproc"
subcategory: "Endpoints"
subcategory: "Google Cloud Run"
subcategory: "Google Cloud TPU"
subcategory: "Identity-Aware Proxy"
subcategory: "Key Management Service"
subcategory: "Kubernetes (Container) Engine"
subcategory: "ML Engine"
subcategory: "PubSub"
subcategory: "Resource Manager"
subcategory: "RuntimeConfig"
subcategory: "SQL"
subcategory: "Serverless VPC Access"
subcategory: "Service Networking"
subcategory: "Spanner"
subcategory: "Stackdriver Logging"
subcategory: "Stackdriver Monitoring"

[danawillow]

Ah cool, looks like I got excited to review then 😛

A follow-up PR sounds totally fine. Let me know when this one is ready.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b134d19.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[chrisst]

@danawillow ok should be mostly clean now. I added #2590 for the yaml just in case there were downstream changes to other providers.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7da3003.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, d3e1499.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.