Cloudrun v1 by chrisst · Pull Request #2740 · GoogleCloudPlatform/magic-modules

chrisst · 2019-11-22T04:14:24Z

Tasks

need to change import ID to have location as part of it
Fix docs with new import id?
custom_expander to infer namespace from getProject
need to ensure that sql connections can be made with annotations
move tests to GA
add a test that contains traffic
double check of spec.metadata ever comes back as anything.
Finish DomainMapping in a separate PR

fixes hashicorp/terraform-provider-google#4334
fixes hashicorp/terraform-provider-google#4933
service account support for hashicorp/terraform-provider-google#4262

Release Note Template for Downstream PRs (will be copied)

`cloudrun`: `cloud_run_service` is now at v1. Significant updates have been made to the resource including a breaking schema change.

`cloudrun`: `cloud_run_domain_mapping` is now at v1.

modular-magician · 2019-11-22T04:24:34Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, e85cea2.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1426
depends: GoogleCloudPlatform/terraform-google-conversion#267
depends: hashicorp/terraform-provider-google#4972

modular-magician · 2019-11-22T09:47:41Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c8bc21f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

chrisst · 2019-11-22T21:37:53Z

I'm going to fix tests and remove the call to Compute for project comparison then I'll re-request.

modular-magician · 2019-11-22T22:31:58Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5c8430d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-11-22T23:39:02Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, addf7d5.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye · 2019-11-22T23:40:45Z

@chrisst still reviewing but i updated the auto-changelog - now if you have multiple items, put them in different release notes like so. Also, it's technically not new, right? I put them as breaking-changes, but feel free to change.

chrisst · 2019-11-23T00:02:03Z

@emilymye it's new for the GA provider, and breaking change for the Beta provider... does changelog gen handle that?

modular-magician · 2019-11-23T00:19:48Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f8479d8.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-11-23T01:13:10Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c434d43.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

products/cloudrun/api.yaml

products/cloudrun/terraform.yaml

third_party/terraform/tests/resource_cloud_run_service_test.go

products/cloudrun/api.yaml

third_party/terraform/utils/transport.go

modular-magician · 2019-11-25T19:18:22Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 4870072.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-11-25T19:22:31Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 969a61b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-11-25T21:07:23Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 3defec7.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye · 2019-11-25T21:36:36Z

third_party/terraform/utils/transport.go

 		return "", err
 	}
-	return re.ReplaceAllStringFunc(linkTmpl, f), nil
+	final, err := re.ReplaceAllStringFunc(linkTmpl, f), nil


when build works but vet fails on next line (err = nil so err can't be nil)

emilymye · 2019-11-25T21:41:14Z

templates/terraform/flatten_property_method.erb

  <% end -%>
  transformed := make(map[string]interface{})
-  <% property.properties.each do |prop| -%>
+  <% property.properties.reject(&:ignore_read).each do |prop| -%>


i believe we can't do this because it'll cause a diff when we set a nested object to a nested object with no value set for the ignore_read fields - we really need the value for d.Get("a.0.nested.0.field") but that's tough with hashes for sets (see https://github.com/GoogleCloudPlatform/magic-modules/issues/1019)

Ah right. I think in another PR we should just fail on nested ignore_read since right now they appear to be silently not doing anything.

a great idea!

modular-magician · 2019-11-25T22:08:23Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6c098bd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

emilymye

If test pass I am 👍

modular-magician · 2019-11-26T23:50:29Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 6c098bd.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Allow import ids to contain location so that a full GET url can be constructed Enable recursive substituion for replaceVars. This will allow region to be injected into the cloudrun baseurl even when using base url overrides. Add customDiff to support translating project number into a project name. The namespace field supports both but will only return the project number which will result in a permadiff without it.

Introduce metadata for revisions De-nest spec so that revision metadata doesn't collide with the other flattened metadata. Also keeps that metadata scoped to the revision template which makes much more sense logically Add a new test which associates a sql instance with a cloudrun instance

Once the replacement string has been identified an early return from the replaceVars method means not checking every subsequent block to see if the string has already been found. However we always need to identify if the final substitution contains another replacable variable.

Reasons added in the comments for metadata.namespace

updating ID's for domainMapping and Service

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

googlebot added the cla: yes label Nov 22, 2019

modular-magician added downstream-generated terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels Nov 22, 2019

chrisst force-pushed the cloudrun-v1 branch 2 times, most recently from d472385 to d1154e0 Compare November 22, 2019 06:34

GoogleCloudPlatform deleted a comment from modular-magician Nov 22, 2019

chrisst force-pushed the cloudrun-v1 branch from 83547d9 to c8bc21f Compare November 22, 2019 09:37

chrisst requested a review from emilymye November 22, 2019 09:37

chrisst changed the title ~~WIP - Cloudrun v1~~ Cloudrun v1 Nov 22, 2019

chrisst removed the request for review from emilymye November 22, 2019 21:37

chrisst assigned emilymye Nov 22, 2019

chrisst mentioned this pull request Nov 22, 2019

Declare Cloud SQL instance for google_cloud_run_service hashicorp/terraform-provider-google#4885

Closed

emilymye self-requested a review November 22, 2019 23:28

emilymye removed their assignment Nov 22, 2019

chrisst force-pushed the cloudrun-v1 branch from addf7d5 to f8479d8 Compare November 23, 2019 00:10

emilymye reviewed Nov 23, 2019

View reviewed changes

chrisst force-pushed the cloudrun-v1 branch from c434d43 to 4870072 Compare November 25, 2019 19:06

chrisst mentioned this pull request Nov 25, 2019

Upgrade DomainMapping to v1 chrisst/magic-modules#4

Closed

chrisst requested a review from emilymye November 25, 2019 21:05

emilymye reviewed Nov 25, 2019

View reviewed changes

emilymye approved these changes Nov 26, 2019

View reviewed changes

chrisst added the terraform-3.0 label Nov 26, 2019

modular-magician added the automerged label Nov 27, 2019

Chris Stephens added 16 commits November 26, 2019 16:08

Catch fields up as of v1

aafe61a

Default to global project for namespace

0a0dd41

Move tests to GA and fix imports

15b6ec0

remove custom import in favor of import_format

09e240c

fix traffic block and tests

bd614bc

Remove comparison of namespace to API value

317b6b9

Reasons added in the comments for metadata.namespace

Cleaning up comments and todos

c00d803

Fix ignore_read for nested and flattened properties

cecfc7c

code review cleanup

2a01684

Break up 80+ char descriptions

7d5278a

Upgrade DomainMapping to v1

8334cd2

updating ID's for domainMapping and Service

Refactor recursive substitution

8ee7a93

Remove ignore_read and fix replace err check

b7dad40

chrisst force-pushed the cloudrun-v1 branch from 6c098bd to b7dad40 Compare November 27, 2019 00:10

Update tracked submodules -> HEAD on Wed Nov 27 00:15:55 UTC 2019

34a2ec3

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician merged commit 264ac86 into GoogleCloudPlatform:master Nov 27, 2019

chrisst mentioned this pull request Nov 27, 2019

Adding notes about cloudrun to upgrade guide #2753

Merged

slevenick mentioned this pull request Dec 2, 2019

Add support for Service Accounts and IAM roles to Cloud Run hashicorp/terraform-provider-google#4262

Closed

Conversation

chrisst commented Nov 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Nov 22, 2019

Pull request statuses

New Pull Requests

Uh oh!

modular-magician commented Nov 22, 2019

Pull request statuses

New Pull Requests

Uh oh!

chrisst commented Nov 22, 2019

Uh oh!

modular-magician commented Nov 22, 2019

Pull request statuses

New Pull Requests

Uh oh!

modular-magician commented Nov 22, 2019

Pull request statuses

New Pull Requests

Uh oh!

emilymye commented Nov 22, 2019

Uh oh!

chrisst commented Nov 23, 2019

Uh oh!

modular-magician commented Nov 23, 2019

Pull request statuses

New Pull Requests

Uh oh!

modular-magician commented Nov 23, 2019

Pull request statuses

New Pull Requests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

modular-magician commented Nov 25, 2019

Pull request statuses

New Pull Requests

Uh oh!

modular-magician commented Nov 25, 2019

Pull request statuses

New Pull Requests

Uh oh!

modular-magician commented Nov 25, 2019

Pull request statuses

New Pull Requests

Uh oh!

emilymye Nov 25, 2019

Choose a reason for hiding this comment

Uh oh!

emilymye Nov 25, 2019

Choose a reason for hiding this comment

Uh oh!

chrisst Nov 25, 2019

Choose a reason for hiding this comment

Uh oh!

emilymye Nov 25, 2019

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Nov 25, 2019

Pull request statuses

New Pull Requests

Uh oh!

emilymye left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Nov 26, 2019

Pull request statuses

New Pull Requests

Uh oh!

Reviewers

Assignees

Labels

Projects

chrisst commented Nov 22, 2019 •

edited

Loading