[Compute_Disk] - Add beta multi-writer support

[ScottSuarez]

Add multi-writer support for Compute Disk. Resolves 6953

Note: When creating a disk with multiwriter in test scenario I encountered the following error.

Any advice @danawillow , @c2thorn

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `multiwriter` to resource `disk` (beta)

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@danawillow, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 3 files changed, 88 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

[ScottSuarez]

After investigating it seems this feature is still in alpha and is whitelist only.

Will wait to add support until it is released to beta.

[gdsotirov]

@ScottSuarez Isn't this feature already in beta? E.g. see https://cloud.google.com/sdk/gcloud/reference/beta/compute/disks/create#--multi-writer

[ScottSuarez]

@gdsotirov Hey! Thanks for checking up on this. Last time I looked into it the feature was whitelist only. It's possible that now it's been released to beta. I'll take another look and see if we can support this at this time

[ScottSuarez]

@gdsotirov Hey so I've looked into it again its it's still not beta, alpha only. Looks to release at the end of this month pending any issue. Will continue to track on my end.

[ScottSuarez]

update.. still waiting for release ...

[samuelrac]

I'm waiting...

[ScottSuarez]

@SamuelGeek
https://issuetracker.google.com/164841448

[ScottSuarez]

* updated with the external link

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

[ScottSuarez]

This feature is now available. I will work to get this change in now.

Thanks for your patience. @SamuelGeek @gdsotirov

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 3 files changed, 87 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=164687"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 4 files changed, 88 insertions(+), 1 deletion(-))
Inspec: Diff ( 4 files changed, 7 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=164688"

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 3 files changed, 87 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=164693"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceStorageBucketObjectContent_Basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccComputeInstance_multiWriter|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccContainerCluster_withIPv4Error|TestAccDataprocJob_Spark You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=164703"

[rileykarson]

nit: Mind reformatting the changelog? I recognise it's been a while since you wrote it 🙂

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 3 files changed, 91 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=164768"

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 3 files changed, 91 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=164787"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceStorageBucketObjectContent_Basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccComputeDisk_multiWriter|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccContainerCluster_withIPv4Error|TestAccContainerNodePool_withKubeletConfig|TestAccDataprocJob_Spark You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=164792"