Skip to content

Added field graceful_decomissioning_timeout to resource dataproc_cluster#4078

Merged
ScottSuarez merged 3 commits intoGoogleCloudPlatform:masterfrom
ScottSuarez:graceful-decomissioning
Oct 9, 2020
Merged

Added field graceful_decomissioning_timeout to resource dataproc_cluster#4078
ScottSuarez merged 3 commits intoGoogleCloudPlatform:masterfrom
ScottSuarez:graceful-decomissioning

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

@ScottSuarez ScottSuarez commented Oct 9, 2020

Added field graceful_decomissioning_timeout to resource dataproc_cluster
Closes 3999

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataproc: Added `graceful_decomissioning_timeout` field to `dataproc_cluster` resource

@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@modular-magician
Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 30 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 30 insertions(+), 9 deletions(-))
Inspec: Diff ( 4 files changed, 7 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151416"

@modular-magician
Copy link
Copy Markdown
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 30 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 30 insertions(+), 9 deletions(-))
Inspec: Diff ( 4 files changed, 7 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151418"

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccProviderMeta_setModuleName|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withLifecycleConfigIdleDeleteTtl|TestAccDataprocCluster_withAutoscalingPolicy You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151420"

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 29 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 3 files changed, 29 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151426"

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccProviderMeta_setModuleName You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151432"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates to dataproc cluster num workers should have option to use graceful decomissioning.

3 participants