region NEG moved to TPG#4139
Conversation
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 1089 insertions(+), 14 deletions(-)) |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153627" |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153645" |
danawillow
left a comment
There was a problem hiding this comment.
Looks good! I updated the release note a bit for clarity (since it's not moving out of the beta provider, it's just also in GA now) and updated the PR description so that it closes the issue on merge. Take a look at the changes I made :)
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
fixes hashicorp/terraform-provider-google#7479