adding data source for identity pool provider#4181
Conversation
Co-authored-by: Scott Suarez <ScottSuarez@google.com>
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 9 files changed, 406 insertions(+), 11 deletions(-)) |
|
@wvanderdeijl: let me know if this is ready to review, or if you need to do anything else before I do! |
|
@rileykarson I have merged master into this so the PR now only contains the actual changes for the new datasource. |
|
@rileykarson is this one good to go, or do you want me to change some things? |
rileykarson
left a comment
There was a problem hiding this comment.
LGTM
Sorry about the delay! I've been fairly busy, so it's taking me longer than usual to make code review passes.
|
Gonna run the VCR tests with /gcbrun before merging, I don't expect it to fail though. |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156220" |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceSpannerInstance_basic|TestAccBigqueryDataTransferConfig|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_vpcConnector|TestAccGameServicesGameServerConfig_gameServiceConfigBasicExample|TestAccGameServicesGameServerDeploymentRollout_gameServiceDeploymentRolloutBasicExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156235" |
| } | ||
|
|
||
| resource "google_iam_workload_identity_pool_provider" "bar" { | ||
| workload_identity_pool_id = "pool-%{random_suffix}" |
There was a problem hiding this comment.
You'll want to interpolate this value off the google_iam_workload_identity_pool above, otherwise this gets created at the same time as it's parent.
rileykarson
left a comment
There was a problem hiding this comment.
One small thing! There was a test failure because the dependency graph wasn't complete.
|
/gcbrun |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156244" |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceSpannerInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_update|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesPackagesExample|TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156331" |
final part of hashicorp/terraform-provider-google#7455
this add a datasource for google_iam_workload_identity_pool_provider similar to the datasource google_iam_workload_identity_pool that was added in #4134 This is the data source version of the resource that is added in #4129
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Fixes hashicorp/terraform-provider-google#7455
I'll keep this in draft until #4129 is merged as this branch also includes those changes. The diff will clean up to only the data source changes once that PR is merged