Skip to content

Restrict annotation ignores to the specific annotation Cloud Run adds#4202

Merged
ScottSuarez merged 1 commit intoGoogleCloudPlatform:masterfrom
ScottSuarez:restrict-annotation-ignores
Nov 7, 2020
Merged

Restrict annotation ignores to the specific annotation Cloud Run adds#4202
ScottSuarez merged 1 commit intoGoogleCloudPlatform:masterfrom
ScottSuarez:restrict-annotation-ignores

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

Restrict the diff suppress to only ignore the fields Cloud Run adds

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 7 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 7 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156454"

@nat-henderson
Copy link
Copy Markdown
Contributor

(assuming the tests pass!)

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigqueryDataTransferConfig|TestAccCloudRunService_cloudRunServiceUpdate|TestAccComposerEnvironment_withUpdateOnCreate|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_update|TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=156537"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants