Add Cloud Run Locations datasource#4360
Add Cloud Run Locations datasource#4360rileykarson merged 12 commits intoGoogleCloudPlatform:masterfrom
Conversation
Fork Update
Co-authored-by: upodroid <cy@borg.dev>
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-)) |
|
|
||
| func flattenCloudRunLocations(resp map[string]interface{}) []interface{} { | ||
| regionList := resp["locations"].([]interface{}) | ||
| regions := make([]interface{}, len(regionList)) |
There was a problem hiding this comment.
Is there a reason why we don't use strong types here? Locations response struct exists in run/v1 package.
There was a problem hiding this comment.
Hmm, it looks like the team is using raw HTTP calls instead of adding new google.golang.org/api packages for new datasources. It is messier though
There was a problem hiding this comment.
In general it's fine either way- for example I want to say the TPU service library didn't exist yet, or we hadn't imported the service library and preferred not to.
|
|
||
| func flattenCloudRunLocations(resp map[string]interface{}) []interface{} { | ||
| regionList := resp["locations"].([]interface{}) | ||
| regions := make([]interface{}, len(regionList)) |
There was a problem hiding this comment.
In general it's fine either way- for example I want to say the TPU service library didn't exist yet, or we hadn't imported the service library and preferred not to.
third_party/terraform/website/docs/d/cloud_run_locations.html.markdown
Outdated
Show resolved
Hide resolved
… into cloud-run-locations
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-)) |
1 similar comment
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-)) |
|
/gcbrun |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=165642" |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 13 files changed, 252 insertions(+), 20 deletions(-)) |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleSubnetwork|TestAccDataSourceStorageBucketObjectContent_Basic|TestAccCloudRunServiceIamBindingGenerated|TestAccCloudRunServiceIamMemberGenerated|TestAccCloudRunServiceIamPolicyGenerated|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceBasicExample|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudRunService_cloudRunServiceNoauthExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccDataprocJob_Spark You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=165649" |
|
Thanks for contributing this. I personally really appreciate. |
Fixes: hashicorp/terraform-provider-google#7850
@ahmetb
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)