Add requested policy version to folder IAM GET#4401
Add requested policy version to folder IAM GET#4401slevenick merged 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167142" |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample|TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample|TestAccFolderIamAuditConfig_update|TestAccFolderIamAuditConfig_basic|TestAccFolderIamAuditConfig_addFirstExemptMember|TestAccFolderIamAuditConfig_removeLastExemptMember|TestAccFolderIamAuditConfig_updateNoExemptMembers|TestAccFolderIamBinding_update|TestAccFolderIamBinding_basic|TestAccFolderIamMember_basic|TestAccFolderIamPolicy_basic|TestAccFolderIamPolicy_auditConfigs You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167149" |
melinath
left a comment
There was a problem hiding this comment.
Could you add a test that would have caught this error?
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167358" |
melinath
left a comment
There was a problem hiding this comment.
Thanks! LGTM assuming tests pass.
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccApigeeOrganization_apigeeOrganizationCloudFullTestExample|TestAccApigeeOrganization_apigeeOrganizationCloudBasicTestExample|TestAccCloudRunService_cloudRunServiceMultipleEnvironmentVariablesExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167369" |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=167371" |
Fixes: hashicorp/terraform-provider-google#8186
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)