Retry on Cloud Run 409s (foreground deletion)

[rileykarson]

Fixes hashicorp/terraform-provider-google#7854

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrun: Terraform will attempt to retry 409 errors from the Cloud Run API, which may be returned intermittently on create.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 176 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 7 files changed, 176 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170712"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 176 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 7 files changed, 176 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170725"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityCmekExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170728"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 145 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 7 files changed, 145 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170730"

[modular-magician]

Tests failed during RECORDING mode: TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 145 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 7 files changed, 145 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170733"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityCmekExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170739"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityCmekExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170740"

[modular-magician]

Tests failed during RECORDING mode: TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

[modular-magician]

Tests failed during RECORDING mode: TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityCmekExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170741"

[modular-magician]

Tests failed during RECORDING mode: TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 147 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 7 files changed, 147 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 18 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170953"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 181 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 8 files changed, 181 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=170958"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 181 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 8 files changed, 181 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171152"

[rileykarson]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 181 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 8 files changed, 181 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[rileykarson]

2 failures in https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/171475

One is an existing failing test (TestAccCloudRunService_cloudRunServiceSqlExample), and the second is TestAccCloudRunDomainMapping_foregroundDeletion whose API stops returning 409s too soon. It's an improvement to retry 409s for that resource (the test would fail without the retries), and the issue should get fixed upstream- what's your call on merging @slevenick?

[slevenick]

Do we have an ETA on that upstream fix? I'd prefer to not add a test that fails if we can avoid it

[rileykarson]

Knowing the typical timeline for API-side changes it'll be O(weeks). I can change it to ExpectError?

[slevenick]

Knowing the typical timeline for API-side changes it'll be O(weeks). I can change it to ExpectError?

That's a good solution. Also include a note so whoever notices the failure can tell what to do when it starts failing!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 190 insertions(+), 137 deletions(-))
Terraform Beta: Diff ( 9 files changed, 190 insertions(+), 137 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171479"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccCloudRunService_foregroundDeletion You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171483"

[modular-magician]

Tests failed during RECORDING mode: TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 190 insertions(+), 137 deletions(-))
Terraform Beta: Diff ( 9 files changed, 190 insertions(+), 137 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171486"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171581"

[modular-magician]

Tests failed during RECORDING mode: TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 183 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 8 files changed, 183 insertions(+), 13 deletions(-))
TF Conversion: Diff ( 2 files changed, 16 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171675"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=171679"