fixed maintenance_exclusion deletion#4541
Merged
edwardmedia merged 1 commit intoGoogleCloudPlatform:masterfrom Mar 2, 2021
Merged
fixed maintenance_exclusion deletion#4541edwardmedia merged 1 commit intoGoogleCloudPlatform:masterfrom
edwardmedia merged 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
Collaborator
Collaborator
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=174616" |
rileykarson
reviewed
Feb 26, 2021
Collaborator
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccServiceUsageConsumerQuotaOverride_regionConsumerQuotaOverrideExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=174707" |
rileykarson
approved these changes
Mar 2, 2021
This was referenced Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#8566
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)