Remove release channel UNSPECIFIED diff suppress

[c2thorn]

Fixes hashicorp/terraform-provider-google#8543

The diff suppress made setting channel = "UNSPECIFIED" not set a channel at all, which now causes a diff due to an API change setting a default.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: fixed an issue where release channel UNSPECIFIED could not be set

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 5 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 1 file changed, 5 insertions(+), 6 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=175177"

[rileykarson]

LGTM, as we'll know this works when the tests pass, right?

[c2thorn]

@rileykarson ATM there isn't a test that captures the failing scenario.

magic-modules/mmv1/third_party/terraform/tests/resource_container_cluster_test.go.erb

Line 444 in 5b6b9cb

func TestAccContainerCluster_withReleaseChannelEnabled(t *testing.T) {

is close but actually passes right now because UNSPECIFIED is set during update.

magic-modules/mmv1/third_party/terraform/tests/resource_container_node_pool_test.go.erb

Line 1180 in 5d930d4

func testAccContainerNodePool_withManagement(cluster, nodePool, management string) string {

is failing because the API changed the default release channel, which my PR doesn't override (and we shouldn't do right?). If we explicitly set the channel to UNSPECIFIED here, that will both fix the test and also capture the failing scenario going forward.

[rileykarson]

Good point about TestAccContainerNodePool_withManagement! I was going to suggest adding the UNSPECIFIED channel, which it looks like you've already done. Once that's passing I'm 👍

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 6 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=175183"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceUsageConsumerQuotaOverride_regionConsumerQuotaOverrideExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=175285"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withManagement|TestAccServiceUsageConsumerQuotaOverride_regionConsumerQuotaOverrideExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=175287"

[c2thorn]

Test has passed: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/175190?buildTab=tests

Going to merge now so the fix goes into next release.