datacatalog: Added google_data_catalog_tag_template_iam_*#4590
datacatalog: Added google_data_catalog_tag_template_iam_*#4590rileykarson merged 1 commit intoGoogleCloudPlatform:masterfrom
google_data_catalog_tag_template_iam_*#4590Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 766 insertions(+), 2 deletions(-)) |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177178" |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleCloudRunLocations_basic|TestAccDataSourceGameServicesGameServerDeploymentRollout_basic|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceGoogleActiveFolder_default|TestAccDataSourceDNSKeys_basic|TestAccDataSourceDnsManagedZone_basic|TestAccDataSourceCloudIdentityGroups_basic|TestAccDataSourceCloudIdentityGroupMemberships_basic|TestAccDataSourceGoogleAppEngineDefaultServiceAccount_basic|TestAccDataSourceGoogleActiveFolder_space|TestAccDataSourceGoogleBigqueryDefaultServiceAccount_basic|TestAccDataSourceGoogleBillingAccount_byFullName|TestAccDataSourceGoogleBillingAccount_byShortName|TestAccDataSourceGoogleCloudRunService_optionalProject|TestAccDataSourceGoogleCloudRunService_basic|TestAccDataSourceGoogleActiveFolder_dash|TestAccDataSourceGoogleClientOpenIDUserinfo_basic|TestAccDataSourceComposerImageVersions_basic|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceComputeAddress|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComputeImage|TestAccDataSourceComputeImageFilter|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceComputeNodeTypes_basic|TestAccInstanceTemplateDatasource_filter|TestAccInstanceTemplateDatasource_name|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceGoogleNetwork|TestAccComputeRegions_basic|TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeRouter|TestAccComputeZones_basic|TestAccDataSourceComputeSslCertificate|TestAccDataSourceGoogleSslPolicy|TestAccContainerEngineVersions_basic|TestAccDataSourceGoogleSubnetwork|TestAccComputeZones_filter|TestAccDataSourceGoogleVpnGateway|TestAccContainerEngineVersions_filtered|TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccDataSourceGoogleFolder_byFullName|TestAccDataSourceGoogleFolderOrganizationPolicy_basic|TestAccDataSourceGoogleFolder_byShortName|TestAccDataSourceGoogleFolder_lookupOrganization|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceIAMRole|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataKmsSecretCiphertext_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccDataSourceGoogleMonitoringUptimeCheckIps_basic|TestAccDataSourceGoogleKmsCryptoKeyVersion_basic|TestAccDataSourceGoogleOrganization_byFullName|TestAccDataSourceGoogleOrganization_byShortName|TestAccDataSourceGoogleProjects_basic|TestAccDataSourceGoogleProjectOrganizationPolicy_basic|TestAccDatasourceGoogleServiceAccountKey_basic|TestAccDataSourceGoogleStorageProjectServiceAccount_basic|TestAccDatasourceGoogleServiceAccount_basic|TestAccDataSourceGoogleProject_basic|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceGoogleStorageTransferProjectServiceAccount_basic|TestAccDataSourceIAMBetaWorkloadIdentityPoolProvider_basic|TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayName|TestAccDataSourceGoogleMonitoringNotificationChannel_byTypeAndLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_UserLabel|TestAccDataSourceGoogleMonitoringNotificationChannel_byDisplayNameAndType|TestAccDataSourceMonitoringService_AppEngine|TestAccDataSourceGooglePubsubTopic_optionalProject|TestAccDataSourceGooglePubsubTopic_basic|TestAccRedisInstanceDatasource_basic|TestAccRuntimeconfigConfigDatasource_basic|TestAccRuntimeconfigVariableDatasource_basic|TestAccDatasourceSecretManagerSecretVersion_basic|TestAccDatasourceSecretManagerSecretVersion_latest|TestAccIapClient_Datasource_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccTPUTensorflowVersions_basic|TestAccDataSourceStorageBucketObjectContent_Basic|TestAccDataSourceGoogleIamTestablePermissions_basic|TestAccDataCatalogTagTemplateIamBindingGenerated|TestAccDataCatalogTagTemplateIamMemberGenerated|TestAccDataCatalogTagTemplateIamPolicyGenerated|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccBigQueryDataset_cmek|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccBigQueryJob_bigqueryJobCopyExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=177179" |
|
Tests failed during RECORDING mode: TestAccDataSourceComputeInstanceSerialPort_basic|TestAccRuntimeconfigConfigDatasource_basic|TestAccRuntimeconfigVariableDatasource_basic|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated Please fix these to complete your PR |
rileykarson
left a comment
There was a problem hiding this comment.
Sorry for the delay in getting to this!
I added IAM-related resources for Data Catalog TagTemplate so that resource-level IAM can be configured using Terraform.
It's just a quick fix, so I haven't opened an issue.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)