Skip to content

add handling of empty versioning and cors in hand written storage bucket#4608

Merged
rileykarson merged 1 commit intoGoogleCloudPlatform:masterfrom
daniel-cit:bugfix/fix-storage-bucket-empty-properties
Mar 19, 2021
Merged

add handling of empty versioning and cors in hand written storage bucket#4608
rileykarson merged 1 commit intoGoogleCloudPlatform:masterfrom
daniel-cit:bugfix/fix-storage-bucket-empty-properties

Conversation

@daniel-cit
Copy link
Copy Markdown
Contributor

This PR solves the issue Validator crashes when validating storage resource when versioning is not yet defined in terraform-validator

Release Note Template for Downstream PRs (will be copied)

Fix handling of empty versioning and cors in hand written storage bucket for terraform-google-conversion

@google-cla google-cla bot added the cla: yes label Mar 19, 2021
@modular-magician
Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

TF Conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=178049"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants