Add conflictswith on autopilot to node config#4674
Merged
slevenick merged 1 commit intoGoogleCloudPlatform:masterfrom Apr 14, 2021
Merged
Add conflictswith on autopilot to node config#4674slevenick merged 1 commit intoGoogleCloudPlatform:masterfrom
slevenick merged 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
Collaborator
Collaborator
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=181271" |
Collaborator
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccDataprocCluster_withConfigOverrides You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=181277" |
Collaborator
|
Tests failed during RECORDING mode: TestAccDataprocCluster_withConfigOverrides|TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR |
c2thorn
approved these changes
Apr 14, 2021
Member
c2thorn
left a comment
There was a problem hiding this comment.
Shouldn't be a breaking change, as node_configs+enable_autopilot leaves a permadiff anyway
This was referenced Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: hashicorp/terraform-provider-google#8863
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)