dns/api.yaml: add missing record types#4689
dns/api.yaml: add missing record types#4689melinath merged 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records. In particular this was hurting people who were previously deploying DNSSEC key records via terraform. Closes hashicorp/terraform-provider-google#8897
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=182080" |
Due to internal funding procedures it would be a fiddle to set up a Google project which could create real resources. |
I get a lot of go fmt problems apparently unrelated to this PR so I suspect I may be doing this wrong. |
But once I run |
|
There were a couple of build issues yesterday that were unrelated to this PR so let's do a new /gcbrun |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=182289" |
melinath
left a comment
There was a problem hiding this comment.
LGTM in principle assuming tests pass :-)
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=182291" |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccComputeRouterPeer_advertiseMode|TestAccTags You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=182296" |
|
Tests failed during RECORDING mode: TestAccCloudRunDomainMapping_foregroundDeletion Please fix these to complete your PR |
Update the list of valid DNS record types to match the list documented at https://cloud.google.com/dns/docs/records.
In particular this was hurting people who were previously deploying DNSSEC key records via terraform.
Fixes hashicorp/terraform-provider-google#8897
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)