Skip to content

Adding shielded config values to dataproc_cluster#4694

Merged
ScottSuarez merged 5 commits intoGoogleCloudPlatform:masterfrom
ScottSuarez:shielded-config-values
Apr 14, 2021
Merged

Adding shielded config values to dataproc_cluster#4694
ScottSuarez merged 5 commits intoGoogleCloudPlatform:masterfrom
ScottSuarez:shielded-config-values

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

closes hashicorp/terraform-provider-google#8092

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataproc: added `shielded_instance_config` fields to `google_dataproc_cluster`

@ScottSuarez ScottSuarez requested review from a team and c2thorn and removed request for a team April 13, 2021 20:36
@google-cla google-cla bot added the cla: yes label Apr 13, 2021
@ScottSuarez ScottSuarez requested review from a team and slevenick and removed request for a team and c2thorn April 13, 2021 20:43
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 80 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 81 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=182112"

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 105 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 105 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=182113"

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 105 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 105 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=182115"

Copy link
Copy Markdown
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 105 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 105 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=182122"

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudRunDomainMapping_foregroundDeletion|TestAccComputeRouterPeer_advertiseMode|TestAccDataprocCluster_withInternalIpOnlyTrueAndShieldedConfig You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=182225"

@ScottSuarez
Copy link
Copy Markdown
Contributor Author

ran individual test separately, failed in tc for unrelated issue on initial run.
https://ci-oss.hashicorp.engineering/viewLog.html?buildId=182295&

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support shielded instance configs for creating google dataproc cluster

3 participants