Skip to content

Add HA VPN Gateway Datasource#4710

Merged
rileykarson merged 17 commits intoGoogleCloudPlatform:masterfrom
borg-land:ha-vpn-ds
Apr 19, 2021
Merged

Add HA VPN Gateway Datasource#4710
rileykarson merged 17 commits intoGoogleCloudPlatform:masterfrom
borg-land:ha-vpn-ds

Conversation

@upodroid
Copy link
Copy Markdown
Contributor

Fixes: hashicorp/terraform-provider-google#3737

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_ha_vpn_gateway`

@google-cla google-cla bot added the cla: yes label Apr 19, 2021
@modular-magician
Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 129 insertions(+))
Terraform Beta: Diff ( 5 files changed, 129 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183056"

Copy link
Copy Markdown
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

X-post from magic-modules: missing datasource google_compute_ha_vpn_gateway

3 participants