Skip to content

fixed default for max_throughput#4823

Merged
edwardmedia merged 2 commits intoGoogleCloudPlatform:masterfrom
edwardmedia:issue9228
Jun 2, 2021
Merged

fixed default for max_throughput#4823
edwardmedia merged 2 commits intoGoogleCloudPlatform:masterfrom
edwardmedia:issue9228

Conversation

@edwardmedia
Copy link
Copy Markdown
Contributor

@edwardmedia edwardmedia commented May 29, 2021

Fixes hashicorp/terraform-provider-google#9228

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vpcaccess: fixed permadiff when `max_throughput` is not set on `google_vpc_access_connector`

@google-cla google-cla bot added the cla: yes label May 29, 2021
@modular-magician
Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 6 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 66 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=189696"

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 4 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 64 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190181"

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAppEngineStandardAppVersion_update|TestAccCloudFunctionsFunction_vpcConnector|TestAccVPCAccessConnector_vpcAccessConnectorThroughput|TestAccVPCAccessConnector_vpcAccessConnectorExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190182"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_vpc_access_connector getting redeployed on every terraform apply without changes in configuration

3 participants