Fix composer environment version regexp#5039
Merged
rileykarson merged 1 commit intoGoogleCloudPlatform:masterfrom Aug 13, 2021
Merged
Fix composer environment version regexp#5039rileykarson merged 1 commit intoGoogleCloudPlatform:masterfrom
rileykarson merged 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
Collaborator
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
Collaborator
rileykarson
approved these changes
Aug 5, 2021
Member
|
Do you mind rebasing? Sorry, seems there's been a flake in CI that should be resolved by taking in #5038 |
Member
|
This shouldn't require rebasing - /gcbrun should be enough |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Member
|
/gcbrun |
Collaborator
Member
|
Sorry for the delay in getting back! I need to declare an email bankruptcy, or something. |
This was referenced Aug 13, 2021
khajduczenia
pushed a commit
to khajduczenia/magic-modules
that referenced
this pull request
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed environment version regexp to explicitly require
.(dot) instead of any character afterpreviewliteral.Example:
composer-2.0.0-preview.0-airflow-2.1.1.part of hashicorp/terraform-provider-google#9611
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)