wait for instance status only after create/update#5057
wait for instance status only after create/update#5057ScottSuarez merged 9 commits intoGoogleCloudPlatform:masterfrom
Conversation
mmv1/third_party/terraform/resources/resource_compute_instance_group_manager.go.erb
Show resolved
Hide resolved
|
Error trying to cancel build () |
|
looks like everything passed @rileykarson |
mmv1/third_party/terraform/resources/resource_compute_instance_group_manager.go.erb
Show resolved
Hide resolved
|
Error trying to cancel build () |
1 similar comment
|
Error trying to cancel build () |
rileykarson
left a comment
There was a problem hiding this comment.
Your changelog entry is out of date now, right? I'd suggest something user-focused eg:
compute: changed `wait_for_instances` in `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager` to no longer block plan / refresh, waiting on managed instance statuses during apply instead
mmv1/third_party/terraform/resources/resource_compute_instance_group_manager.go.erb
Show resolved
Hide resolved
mmv1/third_party/terraform/resources/resource_compute_instance_group_manager.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/resources/resource_compute_region_instance_group_manager.go.erb
Show resolved
Hide resolved
|
Error trying to cancel build () |
2 similar comments
|
Error trying to cancel build () |
|
Error trying to cancel build () |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccEventarcTrigger_BasicHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201084 |
|
Error trying to cancel build () |
3 similar comments
|
Error trying to cancel build () |
|
Error trying to cancel build () |
|
Error trying to cancel build () |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccBigQueryDataTable_bigtable|TestAccEventarcTrigger_BasicHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201476 |
closes hashicorp/terraform-provider-google#9631
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)