Skip to content

wait for instance status only after create/update#5057

Merged
ScottSuarez merged 9 commits intoGoogleCloudPlatform:masterfrom
ScottSuarez:wait-for-status
Aug 17, 2021
Merged

wait for instance status only after create/update#5057
ScottSuarez merged 9 commits intoGoogleCloudPlatform:masterfrom
ScottSuarez:wait-for-status

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

@ScottSuarez ScottSuarez commented Aug 6, 2021

closes hashicorp/terraform-provider-google#9631

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: changed `wait_for_instances` in `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager` to no longer block plan / refresh, waiting on managed instance statuses during apply instead

@google-cla google-cla bot added the cla: yes label Aug 6, 2021
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 36 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 2 files changed, 37 insertions(+), 22 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 36 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 1 file changed, 36 insertions(+), 21 deletions(-))

@ScottSuarez ScottSuarez marked this pull request as ready for review August 10, 2021 00:34
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 55 insertions(+), 39 deletions(-))
Terraform Beta: Diff ( 3 files changed, 56 insertions(+), 40 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

@ScottSuarez
Copy link
Copy Markdown
Contributor Author

looks like everything passed @rileykarson

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 84 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 2 files changed, 84 insertions(+), 36 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

Copy link
Copy Markdown
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changelog entry is out of date now, right? I'd suggest something user-focused eg:

compute: changed `wait_for_instances` in `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager` to no longer block plan / refresh, waiting on managed instance statuses during apply instead

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 83 insertions(+), 35 deletions(-))
Terraform Beta: Diff ( 4 files changed, 83 insertions(+), 35 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

2 similar comments
@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccEventarcTrigger_BasicHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201084

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 98 insertions(+), 35 deletions(-))
Terraform Beta: Diff ( 5 files changed, 99 insertions(+), 36 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

3 similar comments
@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccBigQueryDataTable_bigtable|TestAccEventarcTrigger_BasicHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

instance_group_manager marked tainted if healthcheck failing

3 participants