Skip to content

consume dcl assured workloads issues fixes#5082

Merged
ScottSuarez merged 3 commits intoGoogleCloudPlatform:masterfrom
ScottSuarez:aw-fix
Aug 17, 2021
Merged

consume dcl assured workloads issues fixes#5082
ScottSuarez merged 3 commits intoGoogleCloudPlatform:masterfrom
ScottSuarez:aw-fix

Conversation

@ScottSuarez
Copy link
Copy Markdown
Contributor

closes hashicorp/terraform-provider-google#9620

Release Note Template for Downstream PRs (will be copied)

assuredworkloads: enhanced resource deletion so `google_assured_workloads_workload` can delete what it creates

@ScottSuarez ScottSuarez requested review from a team and nat-henderson and removed request for a team August 12, 2021 01:48
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@ScottSuarez ScottSuarez removed the request for review from nat-henderson August 12, 2021 01:52
@ScottSuarez ScottSuarez marked this pull request as draft August 12, 2021 01:52
@ScottSuarez
Copy link
Copy Markdown
Contributor Author

reverting to draft... existing issues with upstream change.... looking into it

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 8 insertions(+), 92 deletions(-))
Terraform Beta: Diff ( 7 files changed, 9 insertions(+), 94 deletions(-))

@ScottSuarez ScottSuarez marked this pull request as ready for review August 12, 2021 02:21
@ScottSuarez
Copy link
Copy Markdown
Contributor Author

okay this works I was just doing something silly @ndmckinley

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 8 insertions(+), 92 deletions(-))
Terraform Beta: Diff ( 6 files changed, 10 insertions(+), 93 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccAssuredWorkloadsWorkload_FullHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201085

@ScottSuarez
Copy link
Copy Markdown
Contributor Author

looks like tests passed @ndmckinley

@ScottSuarez
Copy link
Copy Markdown
Contributor Author

meep meep

Copy link
Copy Markdown
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't realize you were looking for my LGTM, sorry. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assured workloads do not work as documented

3 participants