consume dcl assured workloads issues fixes#5082
Merged
ScottSuarez merged 3 commits intoGoogleCloudPlatform:masterfrom Aug 17, 2021
Merged
consume dcl assured workloads issues fixes#5082ScottSuarez merged 3 commits intoGoogleCloudPlatform:masterfrom
ScottSuarez merged 3 commits intoGoogleCloudPlatform:masterfrom
Conversation
Contributor
Author
|
reverting to draft... existing issues with upstream change.... looking into it |
Collaborator
Contributor
Author
|
okay this works I was just doing something silly @ndmckinley |
Collaborator
Collaborator
|
Error trying to cancel build () |
Collaborator
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccAssuredWorkloadsWorkload_FullHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201085 |
Contributor
Author
|
looks like tests passed @ndmckinley |
Contributor
Author
|
meep meep |
nat-henderson
approved these changes
Aug 17, 2021
Contributor
nat-henderson
left a comment
There was a problem hiding this comment.
Ah, didn't realize you were looking for my LGTM, sorry. LGTM.
This was referenced Aug 17, 2021
khajduczenia
pushed a commit
to khajduczenia/magic-modules
that referenced
this pull request
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes hashicorp/terraform-provider-google#9620
Release Note Template for Downstream PRs (will be copied)