Send billing_project for every request when set#5086
Send billing_project for every request when set#5086rileykarson merged 4 commits intoGoogleCloudPlatform:masterfrom
Conversation
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 47 insertions(+), 31 deletions(-)) |
c2thorn
left a comment
There was a problem hiding this comment.
magician is adding a duplicate composer import?
ericnorris
left a comment
There was a problem hiding this comment.
This looks good to me! Looking forward to seeing this get merged, thanks for taking the time to upstream it.
|
Hmm- not sure why the import is getting added. Running again. /gcbrun |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 47 insertions(+), 31 deletions(-)) |
|
Error trying to cancel build () |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 47 insertions(+), 32 deletions(-)) |
|
Error trying to cancel build () |
1 similar comment
|
Error trying to cancel build () |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 46 insertions(+), 31 deletions(-)) |
|
Error trying to cancel build () |
2 similar comments
|
Error trying to cancel build () |
|
Error trying to cancel build () |
|
Reconfirmed locally that I see the correct project associations, given I modified the code during the upstreaming. |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201766 |
|
Tests failed during RECORDING mode: TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_update Please fix these to complete your PR |
Upstream of hashicorp/terraform-provider-google#9636, making up for some churn in headers since then and fixing up some documentation that's become fairly stale
This means that more resources will send the project override header, requiring additional permissions on the quota project. I believe that's fine, and safe- the only way a user could run into issues is if they've enabled
user_project_override, defined abilling_project, are using no resources that already supported a billing project (all MMv1 resources, 70%+ of total), and have not granted the appropriate permission to their credentials.If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)