Skip to content

Use a datasource schema for Spanner Instance DS#5395

Merged
rileykarson merged 1 commit intoGoogleCloudPlatform:masterfrom
rileykarson:spanner-ds-test
Oct 29, 2021
Merged

Use a datasource schema for Spanner Instance DS#5395
rileykarson merged 1 commit intoGoogleCloudPlatform:masterfrom
rileykarson:spanner-ds-test

Conversation

@rileykarson
Copy link
Copy Markdown
Member

This didn't seem to cause a failure before but does now w/ the changes to node_count and processing_units. The datasourceSchema call was missing in the initial impl in #4111

$ make testacc TEST=./google-beta TESTARGS='-run=TestAccDataSourceSpannerInstance_basic'
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google-beta -v -run=TestAccDataSourceSpannerInstance_basic -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google-beta/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceSpannerInstance_basic
=== PAUSE TestAccDataSourceSpannerInstance_basic
=== CONT  TestAccDataSourceSpannerInstance_basic
--- PASS: TestAccDataSourceSpannerInstance_basic (24.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta	25.776s

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

spanner: fixed the schema for `data.google_spanner_instance` so that non-configurable fields are considered outputs

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 14 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 2 files changed, 14 insertions(+), 5 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants