Internal CI (run/hello-broken) - Tests failed

[ricardolsmendes]

I've noticed Internal CI (run/hello-broken) is breaking the CI pipeline and preventing unrelated changes to be merged. I'm not familiar with Cloud Run samples, but investigating the error logs generated for a PR I submitted earlier, it turns out Broken resource uses the NAME override might be the culprit.

nodejs-docs-samples/run/hello-broken/test/system.test.js

Lines 79 to 91 in 6f31b84

	it('Broken resource uses the NAME override', async () => {
	const response = await get('/', BASE_URL_OVERRIDE);
	assert.strictEqual(
	response.statusCode,
	200,
	'Did not use the NAME override'
	);
	assert.strictEqual(
	response.body,
	`Hello ${NAME}!`,
	`Expected override "${NAME}" not found`
	);
	});

Would you be able to take a look at this?

Thanks!

[fhinkel]

We know that those tests fail, that's why they're optional for merging.

@grayside any thought on when they'll be fixed?