test(security-center): fix concurrent modification error in management api tests#4318
Open
angelcaamal wants to merge 6 commits into
Open
test(security-center): fix concurrent modification error in management api tests#4318angelcaamal wants to merge 6 commits into
angelcaamal wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the security health analytics custom module tests by moving the SecurityCenterManagementClient instantiation to the describe block scope and adding a client.close() call in the after hook for better resource management. It also introduces a retry mechanism with exponential backoff in the before hook to handle concurrent modification errors (code 10) during module creation. I have no feedback to provide as there were no review comments.
iennae
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Internal : b/515074301
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Fixed API Concurrency Collisions (
package.json)-p -j 2) from thetestscript. Running tests sequentially eliminates the10 ABORTED: Failed to create module due to concurrent modificationerrors caused by workers clashing over the same global resources.Resolved Resource Leaks in Notifications V2 (
ALREADY_EXISTS)uuidv1()to prevent collisions between test runs.afterhook to explicitly delete the Notification Config (deleteNotificationConfig) alongside the Pub/Sub topic, preventing orphaned resources.Stabilized Custom Module Tests (
createSecurityHealthAnalyticsCustomModule)this.retries(3)to gracefully handle any residual API timeouts or flakiness.SecurityCenterManagementClientinstantiation to thedescribeblock scope and addedawait client.close()in the teardown hook to ensure proper gRPC connection closure.Fixed Unhandled Promise Rejections in Mute Rules V2
createMuteConfigAPI call in atry...catchblock. This prevents silent API failures from returningundefinedand throwing misleadingTypeError: (intermediate value) is not iterabledestructuring errors, allowing Mocha to correctly report the underlying API issue.Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.