iot: update misnamed function in gateway_demo#1967
Merged
Conversation
Mike found out that `gateway_demo.py` was still using the old function name `listen_for_config_messages` instead of `listen_for_config_and_error_messages`
googlebot
added
the
cla: yes
gguuss
approved these changes
Jan 10, 2019
Contributor
gguuss
left a comment
gguuss
left a comment
There was a problem hiding this comment.
LGTM. Can you take a look at the failing test? It looks to me like I authored a bug in the test itself where if the device ID includes "400", it will unnecessarily fail. I think it's safe to remove the checks for missing devices attempting to be bound so you can remove the checks in this commit or I can do it in another issue.
Contributor
|
I'll see if I can address this in my PR to fix flaky tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mike found out that
gateway_demo.pywas still using the old function namelisten_for_config_messagesinstead oflisten_for_config_and_error_messageswhich prevented the demo from running