Conversation
googlebot
added
the
cla: yes
speech/api/speech_gcs.py
Outdated
| import argparse | ||
|
|
||
| from gcloud.credentials import get_credentials | ||
| from google.cloud.speech.v1.cloud_speech_pb2 import * # noqa |
Contributor
There was a problem hiding this comment.
Have you done this elsewhere? please never do this.
Contributor
Author
There was a problem hiding this comment.
Yeah - I don't usually, but the auto-generated protobuf libs are pretty opaque about what exactly they declared -_-;
Actually, I realize that I can just import the module. I'll do that... LMKWYT
Contributor
|
Please make travis happy. |
jerjou
force-pushed
the
speech-gcs
branch
2 times, most recently
from
45b89ee to
0f3d214
Compare
speech/api/speech_streaming.py
Outdated
Contributor
There was a problem hiding this comment.
I would rather you not alias it. If you are going to alias it, use cloud_speech.
Contributor
|
LGTM once travis is happy. |
Contributor
Author
|
Me and travis are tight. |
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 9, 2022
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 16, 2022
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 18, 2022
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 18, 2022
engelke
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee
pushed a commit
that referenced
this pull request
Nov 29, 2022
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Dec 2, 2022
dandhlee
pushed a commit
that referenced
this pull request
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that grpc doesn't yet work on python3, so the test is skipped.