Skip to content

fix: prevent scaling plan changes from blocking CI#433

Merged
iennae merged 3 commits intomainfrom
planscaling
Mar 30, 2026
Merged

fix: prevent scaling plan changes from blocking CI#433
iennae merged 3 commits intomainfrom
planscaling

Conversation

@glasnt
Copy link
Copy Markdown
Collaborator

@glasnt glasnt commented Mar 17, 2026

Observed in https://github.com/GoogleCloudPlatform/terraform-dynamic-python-webapp/runs/67362203830

There may be a change to the provider that is causing scaling arguments to change between creation and re-planning when left unchanged:

   ~ resource "google_cloud_run_v2_service" "server" {
         id                      = "projects/ci-dynamic-python-webapp-dc63/locations/us-central1/services/server"
         name                    = "server"
         # (33 unchanged attributes hidden)
 
       - scaling {
           - manual_instance_count = 0 -> null
           - min_instance_count    = 0 -> null
             # (1 unchanged attribute hidden)
         }
 
         # (2 unchanged blocks hidden)
     }
 
 Plan: 0 to add, 1 to change, 0 to destroy.

This change should allow for the template.scaling changes to be ignored, this letting PRs like #425 for unrelated changes pass.

@glasnt
Copy link
Copy Markdown
Collaborator Author

glasnt commented Mar 22, 2026

/gcbrun

@glasnt glasnt marked this pull request as ready for review March 30, 2026 09:01
@glasnt glasnt requested review from a team and donmccasland as code owners March 30, 2026 09:01
@iennae iennae merged commit bf3262d into main Mar 30, 2026
8 checks passed
@iennae iennae deleted the planscaling branch March 30, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants