Add support for specifying sysctls in run options#480
Open
ciarand wants to merge 2 commits into
Open
Conversation
This adds a new "Sysctls" field to the ContainerRunOptions struct. This matches the go-dockerclient definition and just gets passed through to the docker HostConfig struct as-is.
thomasdesr
added a commit
to anyscale/container-structure-test
that referenced
this pull request
Jun 29, 2026
The bazel/test rule smoke-test runs against the pinned prebuilt release (repositories.bzl _VERSION=v1.22.0), which predates the sysctls field added in GoogleContainerTools#480, so it could not parse the fixture and //:test failed on every commit since e9291d6. The fixture validates rule wiring, not new binary features, so it must only use fields the pinned release supports. The sysctls feature itself (pkg/types + docker driver) is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new "Sysctls" field to the ContainerRunOptions struct. This matches the go-dockerclient definition and just gets passed through to the docker HostConfig struct as-is.
Hopefully this is a relatively uncontroversial change.