fix: backport Bazel build context fixes to v1 - #7866
Merged
Conversation
…ContainerTools#7671) * fix: use absolute paths to the container_image.tar in bazel build. * fix unit tests Co-authored-by: tejal29 <tejal29@gmail.com>
mikekamornikov
requested review from
renzodavid9
and removed request for
a team
September 18, 2022 16:50
Codecov Report
@@ Coverage Diff @@
## v1 #7866 +/- ##
=====================================
Coverage ? 68.38%
=====================================
Files ? 563
Lines ? 26692
Branches ? 0
=====================================
Hits ? 18252
Misses ? 7173
Partials ? 1267 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Thanks for the PR @mikekamornikov! Currently I am restarting the Windows Integration Test job as there was a test error (but this is test error likely a flake unrelated to your changes). Once I can verify this is a flake and we have all tests passing we can merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7864
Description
I've backported commits which fix the usage of
Bazelartifact context. Now it's possible to putskaffold.yamlfile to subfolder of bazel workspace and set context to a relative path.Before: