Show every Discourse post w/ excerpt#302
Merged
Merged
Conversation
Contributor
Author
|
Given that this feature is still evolving, I'm going to merge this PR now and we'll see how well it works in practice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #301.
Screenshot:
Notable limitations:
It looks like theWe now rebase the URLs.cookedattribute of posts has relative links, so e.g. if someone mentions@batu, Discourse will turn this into<a href="/users/batu">@batu</a>, which will 404 on NoI. So we might need to rebase the URLs or remove them entirely or something.posts_countfrom the model because it's not useful anymore.post_numberis null, which is useful for migrating existing deployments. However, since "existing deployments" just means noi-demo.thegovlab.org and that's fully under our control, it might be easier to just simplify the code and requirepost_numberto be non-null.