fix(tests): clean up Sprites-side tests from Gradata/tests/#122
Merged
Conversation
After Phase B, mirofish_sim/brain_benchmark/ablation_beta_lb_gate scripts live under Sprites/brain/scripts/ (private). Their tests were sys.path-hacking to find the scripts relative to the repo root — now broken since the public SDK no longer contains them. - Remove the three Sprites-side tests from the public test suite; they live on in Sprites/tests/ (gitignored) for local dogfooding. - Fix test_context_inject_returns_context: patch GRADATA_CONTEXT_INJECT=1 so the test isn't silenced by the kill-switch env var set globally. Gradata/tests now runs clean against the public SDK surface only. Co-Authored-By: Gradata <noreply@gradata.ai>
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 Walkthrough
WalkthroughThis PR removes three complete test modules ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post Phase B (#121), three tests in
Gradata/tests/were sys.path-hacking to reach scripts that now live inSprites/brain/scripts/(private). Also one hook test was failing because it inheritedGRADATA_CONTEXT_INJECT=0from the global kill-switch.test_mirofish_sim.py,test_brain_benchmark.py,test_ablation_beta_lb_gate.py— they test private Sprites scripts, don't belong in the public SDK test suite. Copies live untracked inSprites/tests/for local dogfooding.test_context_inject_returns_contextto setGRADATA_CONTEXT_INJECT=1in its env patch (formatter also reflowed some whitespace).Result:
pytest Gradata/tests/ -qruns clean against the public SDK surface only.Test plan
pytest Gradata/tests/test_hooks_intelligence.py -q— 34 passedGenerated with Gradata