fix: remove ghost references to nonexistent gradata_cloud namespace#170
Conversation
Council 5/7 lenses (council_2026-05-04T15-53-40.md) flagged source comments/docstrings claiming 'proprietary cloud-side', 'requires Gradata Cloud', or referencing the nonexistent gradata_cloud.* namespace as a diligence trap. The gradata_cloud package does not exist on disk or in the Gradata GitHub org. Removed: - contradiction_detector.py: 'similarity is proprietary cloud-side' - rule_integrity.py: 'multi-tenant signing are proprietary cloud-side' - self_improvement/__init__.py: gradata_cloud.graduation reference - meta_rules.py: 'requires Gradata Cloud' (docstring + log line) -> rewrote to factual 'not implemented in open-source build' - test_severity_weighting.py: comment listing gradata_cloud as a target - docs/architecture/multi-tenant-future-proofing.md: gradata_cloud_backup proprietary dashboard claim -> TODO comment Flagged but NOT touched (left as runtime guards per task spec): - src/gradata/cli.py:286,309 - try/except ImportError gates with OSS fallback - src/gradata/enhancements/reporting.py:170 - same pattern - tests/test_brain_events.py - parametrizes ModuleNotFoundError absence - tests/test_severity_weighting.py:42 - try/except ImportError fallback
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 Walkthrough
WalkthroughThis PR updates documentation and comments across the codebase to clarify the open-source/proprietary boundary of Gradata, removes outdated claims about proprietary cloud features, and reorganizes the public API surface of the ChangesDocumentation and Public API Reorganization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 OpenGrep (1.20.0)OpenGrep fatal error (exit code 2): �[32m✔�[39m �[1mOpengrep OSS�[0m �[1m Loading rules from local config...�[0m Comment |
Codex audit identified: - 6 confirmed redundancies (graduation spines, scoring metrics, synthesizer modules, behavioral registries, session histories, deprecated integrations namespace) - Brain god-object split proposal - 5 files >500 lines flagged - 4 dead-code candidates with verification grep - Top 10 cleanups ranked by ROI/risk - 4 conflict-free PR roadmap (naming → integrations → graduation → brain split) Source: /tmp/gradata-autonomous-run/bloat-audit.md (26KB) Triggered: PR #170 (ghost refs) + #169 (tree ranking) revealed surface bloat Co-authored-by: Oliver Le <oliver@spritesai.com>
Summary
Removes ghost references in source comments + docs that claim features
as "proprietary cloud-side", "requires Gradata Cloud", or live in the
nonexistent
gradata_cloud.*/gradata_cloud_backup/namespace.None of those modules exist on disk or in the Gradata GitHub org —
they were aspirational copy that became a diligence trap.
Council verdict: 5/7 lenses agreed in
council_2026-05-04T15-53-40.mdthat these references must bedeleted.
Changes
src/gradata/enhancements/contradiction_detector.pysrc/gradata/enhancements/rule_integrity.pysrc/gradata/enhancements/self_improvement/__init__.pygradata_cloud.graduation.self_improvementsrc/gradata/enhancements/meta_rules.pytests/test_severity_weighting.pygradata_cloud.graduation.self_improvementas a test targetdocs/architecture/multi-tenant-future-proofing.mdgradata_cloud_backup/with a TODO comment (per task: delete-only, no new claims)Flagged but NOT modified
These are real runtime guards (
try / except ImportErrorwith OSSfallback). Per task spec they are left in place — they are not bugs:
src/gradata/cli.py:286—from gradata_cloud.scoring.reports import ...insidetry/except ImportErrorsrc/gradata/cli.py:309— same patternsrc/gradata/enhancements/reporting.py:170— same patterntests/test_brain_events.py— explicitly parametrizes the absence ofgradata_cloudmodules viamonkeypatch.setitem(sys.modules, "gradata_cloud", None)tests/test_severity_weighting.py:42— same try/except fallbackThese are functionally safe (no install break) but do leak the
proprietary module layout in import statements. Deciding whether to
strip them belongs in a separate PR (touches code paths, not just
comments) — flagged here for follow-up.
Test plan
pytest -x --tb=short tests/test_severity_weighting.py tests/test_brain_events.py tests/test_pattern_extractor.py— 99 passedtests/test_dualwrite_atomicity.pyconfirmed present onmainbefore my changes (unrelated, fs-race in test fixture)Layering check
No imports added or moved. Comment-only edits to Layer 1 + tests + docs.
Risk
None — pure copy edits. The single log-line change in
meta_rules.pyis a string-literal swap inside an
_log.info(...)call.