fix(daemon): allow disabling idle-shutdown via GRADATA_DAEMON_IDLE_TIMEOUT#199
Conversation
…MEOUT=0 The daemon used to shut itself down after 10 minutes of no requests. That breaks the dashboard Sync Now button until the 5-minute watchdog cron restarts it. Make IDLE_TIMEOUT_SECONDS env-configurable. Setting GRADATA_DAEMON_IDLE_TIMEOUT=0 disables idle-shutdown entirely — recommended when the daemon is only servicing the dashboard's occasional Sync Now button (long idle stretches are normal).
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 Walkthroughfix(daemon): allow disabling idle-shutdown via GRADATA_DAEMON_IDLE_TIMEOUT
WalkthroughThe daemon's idle auto-shutdown timeout is now configurable via the ChangesConfigurable idle timeout
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 OpenGrep (1.20.0)OpenGrep fatal error (exit code 2): �[32m✔�[39m �[1mOpengrep OSS�[0m �[1m Loading rules from local config...�[0m Comment |
Bug: daemon self-terminates after 10min idle, breaking dashboard Sync Now until the watchdog cron catches up ~5min later. Users perceive intermittent 'Local Gradata daemon not running' errors.
Fix: make IDLE_TIMEOUT_SECONDS env-configurable. Setting GRADATA_DAEMON_IDLE_TIMEOUT=0 disables idle-shutdown entirely. Default unchanged (600s) for backwards compatibility.
Recommended config when daemon is only servicing Sync Now: GRADATA_DAEMON_IDLE_TIMEOUT=0.
Follow-up to #196/#197/#198.