docs: record GRA-370 installer smoke evidence#259
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
📝 Walkthrough
WalkthroughThis PR adds documentation for the GRA-370 installer telemetry and hook registration smoke tests, including verification commands, expected test outcomes, identified environment-contamination failure modes, and host-specific observation notes. ChangesGRA-370 Smoke Test Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Gradata/docs/research/gra-370-installer-telemetry-smoke.md`:
- Around line 28-32: The verification command hardcodes the uv binary path
(/home/olive/.local/bin/uv); update the doc line that runs `env -u BRAIN_DIR -u
GRADATA_BRAIN /home/olive/.local/bin/uv run pytest ...` to invoke uv from PATH
(e.g., `uv run pytest ...`) and add an optional fallback note to use `python -m
uv run pytest ...` if uv is not on PATH; ensure the change is applied where the
tests `tests/test_install_smoke_matrix.py`, `tests/test_cli_install_agent.py`,
and `tests/test_hook_adapters.py` are referenced so the command is portable
across environments.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c6dab4cb-60ba-40b0-bfa4-3caf17dc7615
📒 Files selected for processing (1)
Gradata/docs/research/gra-370-installer-telemetry-smoke.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: pytest (py3.12)
- GitHub Check: pytest (py3.11)
- GitHub Check: pytest macos-latest / py3.12
- GitHub Check: pytest ubuntu-latest / py3.12
- GitHub Check: pytest ubuntu-latest / py3.11
- GitHub Check: pytest windows-latest / py3.11
- GitHub Check: pytest windows-latest / py3.12
- GitHub Check: pytest macos-latest / py3.11
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Gradata
Repo: Gradata/gradata PR: 0
File: :0-0
Timestamp: 2026-04-17T17:18:07.439Z
Learning: In PR `#102` (gradata/gradata), Round 2 addressed: cli.py env-first brain resolution (GRADATA_BRAIN > --brain-dir > cwd), _tenant.py corrupt .tenant_id overwrite, _env_int default clamping to minimum, and _events.py tenant-scoped fallback SELECT for dedup. All ruff and 99 tests green after these fixes.
📚 Learning: 2026-04-17T17:18:07.439Z
Learnt from: Gradata
Repo: Gradata/gradata PR: 0
File: :0-0
Timestamp: 2026-04-17T17:18:07.439Z
Learning: In PR `#102` (gradata/gradata), Round 2 addressed: cli.py env-first brain resolution (GRADATA_BRAIN > --brain-dir > cwd), _tenant.py corrupt .tenant_id overwrite, _env_int default clamping to minimum, and _events.py tenant-scoped fallback SELECT for dedup. All ruff and 99 tests green after these fixes.
Applied to files:
Gradata/docs/research/gra-370-installer-telemetry-smoke.md
Comment on lines
+28
to
+32
| env -u BRAIN_DIR -u GRADATA_BRAIN /home/olive/.local/bin/uv run pytest \ | ||
| tests/test_install_smoke_matrix.py \ | ||
| tests/test_cli_install_agent.py \ | ||
| tests/test_hook_adapters.py \ | ||
| -q |
There was a problem hiding this comment.
Make the verification command portable across environments.
The command currently hardcodes /home/olive/.local/bin/uv, which makes the smoke steps host-specific. Prefer invoking uv from PATH (or document a fallback like python -m uv) so others can reproduce it directly.
Proposed doc fix
-env -u BRAIN_DIR -u GRADATA_BRAIN /home/olive/.local/bin/uv run pytest \
+env -u BRAIN_DIR -u GRADATA_BRAIN uv run pytest \
tests/test_install_smoke_matrix.py \
tests/test_cli_install_agent.py \
tests/test_hook_adapters.py \
-q📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| env -u BRAIN_DIR -u GRADATA_BRAIN /home/olive/.local/bin/uv run pytest \ | |
| tests/test_install_smoke_matrix.py \ | |
| tests/test_cli_install_agent.py \ | |
| tests/test_hook_adapters.py \ | |
| -q | |
| env -u BRAIN_DIR -u GRADATA_BRAIN uv run pytest \ | |
| tests/test_install_smoke_matrix.py \ | |
| tests/test_cli_install_agent.py \ | |
| tests/test_hook_adapters.py \ | |
| -q |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Gradata/docs/research/gra-370-installer-telemetry-smoke.md` around lines 28 -
32, The verification command hardcodes the uv binary path
(/home/olive/.local/bin/uv); update the doc line that runs `env -u BRAIN_DIR -u
GRADATA_BRAIN /home/olive/.local/bin/uv run pytest ...` to invoke uv from PATH
(e.g., `uv run pytest ...`) and add an optional fallback note to use `python -m
uv run pytest ...` if uv is not on PATH; ensure the change is applied where the
tests `tests/test_install_smoke_matrix.py`, `tests/test_cli_install_agent.py`,
and `tests/test_hook_adapters.py` are referenced so the command is portable
across environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paperclip issue: GRA-370
Adds a durable smoke-report artifact for the installer telemetry/hook registration run.
Verification:
Result: