fix(license): get GitHub to recognize AGPL-3.0#58
Merged
Conversation
GitHub shows "Unknown/Other" license because the LICENSE file had two
prefix lines (SPDX-License-Identifier + Copyright (C) 2026 Gradata)
before the canonical AGPL-3.0 text, plus CRLF line endings and a
word-wrap deviation near the boilerplate. Licensee (the gem GitHub
uses via github/linguist) requires >=95% similarity to the SPDX
template, and the prefix bytes + CRLF tanked the match.
- Replaced LICENSE with the exact canonical AGPL-3.0 text from
github/choosealicense.com (LF endings, no BOM, no prefix).
- Added .gitattributes to pin LICENSE to `eol=lf` so core.autocrlf
on Windows cannot re-insert CRLF on checkout.
- SPDX marker + dual-license preamble remain in LICENSE-NOTICE.md
(already present), so the legal notice is preserved.
After merge, `gh api repos/Gradata/gradata --jq .license` should
return `{"key":"agpl-3.0","spdx_id":"AGPL-3.0"}` instead of the
current `{"key":"other","spdx_id":"NOASSERTION"}`.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Gradata has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 Walkthrough
WalkthroughMinimal configuration and licensing updates: a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub currently reports this repo's license as
Other/NOASSERTION:Root cause
GitHub detects licenses via
github/linguist, which delegates to the licensee Ruby gem. Licensee requires theLICENSEfile to match a canonical SPDX template within 0.95 similarity. Our file tanked the match for three reasons:ASCII text, with CRLF line terminators)published by\nthevs canonicalpublished\nby the)Fix
LICENSEwith the exact canonical AGPL-3.0 text fromgithub/choosealicense.com(LF endings, no BOM, no prefix, 662 lines)..gitattributespinningLICENSE text eol=lfso Windowscore.autocrlf=truecannot re-insert CRLF on checkout and break detection again.LICENSE-NOTICE.md, so the legal notice is preserved.Test plan
gh api repos/Gradata/gradata --jq .licensereturns{"key":"agpl-3.0","spdx_id":"AGPL-3.0"}Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com