Publishing doesn't work in Github Actions

[Seggan]

Expected and Results

https://github.com/pylonmc/pylon-core/actions/runs/17285205680/job/49061114241

Task nmcpZipAggregation returns NO-SOURCE and the nmcpPublishAggregationToCentralPortal task fails due to no aggregation generated, yet it works perfectly fine on my machine and even in an act Actions container. Curiously, nmcpPublishAggregationToCentralPortalSnapshots works fine. Also invoking publishMavenPublicationToNmcpRepository in the subproject by itself is fine, its just the aggregation task not working.

Related environment and versions

Gradle 9.0.0
Aggregation plugin version 1.1.0

Reproduction steps

No response

Anything else?

No response

[martinbonnin]

So it fails to resolve the nmcpAggregation configuration:

./gradle dependencyInsight  --configuration nmcpAggregation --dependency pylon-core
project :pylon-core FAILED
   Failures:
      - Could not resolve project :pylon-core.
          - No matching variant of root project : was found. The consumer was configured to find attribute 'com.gradleup.nmcp' with value 'bundle', attribute 'org.gradle.usage' with value 'nmcp' but:
              - No variants exist.
          - Creating consumable variants is explained in more detail at https://docs.gradle.org/9.0.0/userguide/declaring_dependencies.html#sec:resolvable-consumable-configs.
project :pylon-core FAILED

Probably related to gradle/gradle#29037, still digging

[martinbonnin]

Looks like pylon-core is missing a version, which makes the resolution fail. Can you try adding a version there?

[Seggan]

Adding a version to the root project worked! It is very unintuitive however, as adding versions to root projects isn't something one typically does, so I would prefer a more intuitive solution.

[martinbonnin]

adding versions to root projects isn't something one typically does

I don't think you need it in the root project. Setting a version in pylon-core/build.gradle.kts should also work. And this one is probably required anyways if you're going to publish it?

[martinbonnin]

Actually looks like setting a version here other than -SNAPSHOT will do the trick.

[Seggan]

The version is supplied via command line as -Pversion=<version>, and Gradle recognizes it because I use project.version in the build file and it gets the correct version:

[martinbonnin]

Yea, this is super weird. If I do this:

--- a/pylon-core/build.gradle.kts
+++ b/pylon-core/build.gradle.kts
@@ -12,6 +12,9 @@ plugins {
     id("org.jetbrains.dokka-javadoc") version "2.0.0"
 }

+version = "1.0.0"
+println("project version $version")
+

Then this works:

./gradlew dependencyInsight  --configuration nmcpAggregation --dependency pylon-core

But this doesn't:

./gradlew dependencyInsight  --configuration nmcpAggregation --dependency pylon-core -Pversion=1.0.0

Looks like someone else is reading that property and that makes the dependency resolution fail.

[martinbonnin]

I know! Damn I swear it's at least the 3rd time I get hit by this stupid thing. Your root project and your module have the same name and this confuses Gradle dependency resolution somehow 🤷

Try doing this:

--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -1,3 +1,5 @@
+rootProject.name = "pylon-root"

I know it's weird but there's so much we can do sadly...
Edit: we can do something about it and fail with a proper error message when that happens

[Seggan]

Oof yeah lol, an error would have been nice. I'll do that, thank you for all the help!

[martinbonnin]

Sure thing! I'm going to close that now, feel free to leave a comment if you need anything else!