Skip to content

Better error message on missing credentials #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinbonnin merged 1 commit into from
Aug 8, 2025
Merged

Better error message on missing credentials #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions nmcp/src/main/kotlin/nmcp/internal/utils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import nmcp.internal.task.NmcpPublishWithPublisherApiTask
import nmcp.internal.task.registerNmcpFindDeploymentNameTask
import nmcp.internal.task.registerNmcpPublishFileByFileToSnapshotsTask
import nmcp.internal.task.registerNmcpPublishWithPublisherApiTask
import nmcp.nmcpAggregationExtensionName
import nmcp.nmcpExtensionName
import org.gradle.api.Action
import org.gradle.api.Named
import org.gradle.api.Project
Expand Down Expand Up @@ -127,18 +129,30 @@ internal fun Project.registerPublishToCentralPortalTasks(
}
}

/**
* Detect early if the username and/or password are missing.
* This gives feedback to the user before compiling all projects.
*/
project.gradle.taskGraph.whenReady {
val extensionName = when(name) {
"aggregation" -> nmcpAggregationExtensionName
else -> nmcpExtensionName
}
if (it.hasTask(taskPath(project, task.name))) {
check(spec.username.isPresent) {
"Nmcp: username is missing"
"Nmcp: '${extensionName}.username' is missing, check your Nmcp configuration."
}
check(spec.password.isPresent) {
"Nmcp: password is missing"
"Nmcp: '${extensionName}.password' is missing, check your Nmcp configuration."
}
}
}
}

private fun taskPath(project: Project, taskName: String): String {
return "${project.path}:$taskName"
return buildString {
append(project.path)
if (project.path != ":") append(":")
append(taskName)
}
}
7 changes: 5 additions & 2 deletions nmcp/src/main/kotlin/nmcp/plugins.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,17 @@ import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.initialization.Settings

internal val nmcpExtensionName = "nmcp"
internal val nmcpAggregationExtensionName = "nmcpAggregation"

@GPlugin(id = "com.gradleup.nmcp")
internal fun nmcp(project: Project) {
project.extensions.create(NmcpExtension::class.java, "nmcp", DefaultNmcpExtension::class.java, project)
project.extensions.create(NmcpExtension::class.java, nmcpExtensionName, DefaultNmcpExtension::class.java, project)
}

@GPlugin(id = "com.gradleup.nmcp.aggregation")
internal fun nmcpAggregation(project: Project) {
project.extensions.create(NmcpAggregationExtension::class.java, "nmcpAggregation", DefaultNmcpAggregationExtension::class.java, project)
project.extensions.create(NmcpAggregationExtension::class.java, nmcpAggregationExtensionName, DefaultNmcpAggregationExtension::class.java, project)
}

@Suppress("UnstableApiUsage")
Expand Down