Skip to content

Use -- to separate search path #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrantBirki merged 3 commits into from
Apr 15, 2024
Merged

Use -- to separate search path #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5d3b00
Use -- to separate search path
icco Apr 10, 2024
f4aea1a
fix test
GrantBirki Apr 15, 2024
f4c538b
bundle
GrantBirki Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/functions/git-diff.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ test('executes gitDiff by using the git binary', async () => {
'🧮 total detected files changed (json diff): 5'
)
expect(debugMock).toHaveBeenCalledWith(
'running git diff command: git --no-pager diff --no-color --full-index HEAD^1 .'
'running git diff command: git --no-pager diff --no-color --full-index HEAD^1 -- .'
)
})

Expand Down
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/functions/git-diff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export async function gitDiff() {
}

// --no-pager ensures that the git command does not use a pager (like less) to display the diff
const gitDiffCmd = `git --no-pager diff ${gitOptions} ${baseBranch} ${searchPath}`
const gitDiffCmd = `git --no-pager diff ${gitOptions} ${baseBranch} -- ${searchPath}`
core.debug(`running git diff command: ${gitDiffCmd}`)
const {stdout, stderr} = await execAsync(gitDiffCmd, {
maxBuffer: maxBufferSize
Expand Down