add workaround for upstream async dexopt bug#236
Merged
Conversation
Async dexopt was added in Android 16. It has introduced a bug in handling of concurrent installs of the same package. Such installs started to corrupt the internal PackageManager state of the affected packages, which led to system_server crashes when attempting to uninstall them. As a workaround, this commit makes the package installer reject install requests for packages that are already being installed (package updates are considered to be installs too). For more info, see GrapheneOS#230 Based on GrapheneOS#234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async dexopt was added in Android 16. It has introduced a bug in handling of concurrent installs of the same package. Such installs started to corrupt the internal PackageManager state of the affected packages, which led to system_server crashes when attempting to uninstall them.
As a workaround, this commit makes the package installer reject install requests for packages that are already being installed (package updates are considered to be installs too).
For more info, see #230
Based on #234
Closes GrapheneOS/os-issue-tracker#5782